-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Tweak node creator search logic for AI sub-nodes #10025
feat(editor): Tweak node creator search logic for AI sub-nodes #10025
Conversation
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2 flaky tests on run #5898 ↗︎
Details:
e2e/5-ndv.cy.ts • 2 flaky tests
Review all test suite changes for PR #10025 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
if ( | ||
// Filter-out AI sub-nodes if canvas has no AI nodes and the root view is not AI | ||
!(isAiRootView(stack) || canvasHasAINodes) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could extract isAiRootView(stack) || canvasHasAINodes
into a new computed (also used below in groupIfAiRootNodes
|
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR implements the following tweaks for node creator:
node_connection_drop
orplus_endpoint
sourcelastSelectedNode
if chat trigger is auto-addedRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)